Skip to content

Fix NO_PROXY flake#304

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jhadvig:proxy-e2e-flake
Oct 2, 2019
Merged

Fix NO_PROXY flake#304
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jhadvig:proxy-e2e-flake

Conversation

@jhadvig
Copy link
Copy Markdown
Member

@jhadvig jhadvig commented Oct 1, 2019

Have seen the e2e test for the proxy flaking lately with following error:

unable to find environment variable: wanted NO_PROXY

Need to do some investigation, so marking as WIP

/assign @benjaminapetersen

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2019
@benjaminapetersen
Copy link
Copy Markdown
Contributor

benjaminapetersen commented Oct 1, 2019

Great, I see it as well here for #303.

@jhadvig
Copy link
Copy Markdown
Member Author

jhadvig commented Oct 1, 2019

/retest

benjaminapetersen
benjaminapetersen reviewed Oct 2, 2019
View reviewed changes
Comment thread test/e2e/proxy_test.go
}

counter := 0
maxCount := 60
Copy link
Copy Markdown
Contributor

@benjaminapetersen benjaminapetersen Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this simply takes a while to propagate correct?

Copy link
Copy Markdown
Contributor

@benjaminapetersen benjaminapetersen Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to remove the [WIP]?

Copy link
Copy Markdown
Contributor

@benjaminapetersen benjaminapetersen Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps could extract this bit out into a pollDeploymentForEnv func to make it explicit why its needed.

Copy link
Copy Markdown
Member Author

@jhadvig jhadvig Oct 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this simply takes a while to propagate correct?

yes

@jhadvig jhadvig changed the title [WIP] Fix NO_PROXY flake Fix NO_PROXY flake Oct 2, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2019
@jhadvig
Copy link
Copy Markdown
Member Author

jhadvig commented Oct 2, 2019

Ran the test couple of time to see if the flake will show up. Since it didn't occur I think It's ready for review.
@benjaminapetersen PTAL

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2019
@benjaminapetersen
Copy link
Copy Markdown
Contributor

benjaminapetersen commented Oct 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0a66dbe into openshift:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett Awaiting requested review from spadgett

1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jhadvig @benjaminapetersen @openshift-ci-robot @openshift-bot @openshift-merge-robot